JP1 Remotes Forum Index JP1 Remotes


FAQFAQ SearchSearch 7 days of topics7 Days MemberlistMemberlist UsergroupsUsergroups RegisterRegister
ProfileProfile Log in to check your private messagesLog in to check your private messages Log inLog in

SharpDVD - bug fix for protocols.ini

 
Post new topic   Reply to topic    JP1 Remotes Forum Index -> JP1 - Software
View previous topic :: View next topic  
Author Message
The Robman
Site Owner


Joined: 01 Aug 2003
Posts: 19077
Location: Chicago, IL

PostPosted: Thu Apr 04, 2019 10:28 am    Post subject: SharpDVD - bug fix for protocols.ini Reply with quote

re: http://www.hifi-remote.com/forums/viewtopic.php?p=135921#135921

I have a fix for the SharpDVD executor in protocols.ini

The following line:
CmdTranslator=Translator(lsb,comp) XorCheck(4,12,0,2,0;3,4)

Should be changed to this in all 3 versions:
CmdTranslator=Translator(lsb,comp) XorCheck(4,12,1,2,0;3,4)

See the thread linked above for a description of WHY this change is needed.
_________________
Rob
www.hifi-remote.com
Please don't PM me with remote questions, post them in the forums so all the experts can help!
Back to top
View user's profile Send private message Visit poster's website
The Robman
Site Owner


Joined: 01 Aug 2003
Posts: 19077
Location: Chicago, IL

PostPosted: Thu Apr 04, 2019 4:45 pm    Post subject: Reply with quote

I have come up with a new fix for the XOR calculation, it should be replaced with the following:

XorCheck(lsb,comp,4,12,7,2,0;4,0)

But while this change works, I do seek the advice of experts here.

The code originally had "3,4" after the semi-colon, which meant it should skip the first 4 bits of the device code data and use the next 12 bits (ie, 3 units of 4-bits each). However, the result of this was that the device code itself was getting skipped in the calculation. If I just change the devSourceOffset from 4 to 0, it brings in the device code but skips the top half of the sub-device code. If I also change the devCount it brings in both halves of the sub-device code but also brings in the top half of the device code, which results in the result being complimented.

So, what I did was, in addition to adding the LSB and COMP non-positional keyword arguments, I added a seed value of 7 to cover the E value. The true E value is 1 but because all the other numbers are LSB, I should add it as 8, but now I also need to complement it, so I found that using value 7 works (ie, binary 0111 representing a decimal value of 1 in lsb-comp format).

Is there a better way to do this?
_________________
Rob
www.hifi-remote.com
Please don't PM me with remote questions, post them in the forums so all the experts can help!
Back to top
View user's profile Send private message Visit poster's website
Display posts from previous:   
Post new topic   Reply to topic       JP1 Remotes Forum Index -> JP1 - Software All times are GMT - 5 Hours
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum


 

Powered by phpBB © 2001, 2005 phpBB Group
Get Smart! the band's official homepage Rockabilly Central