Posted: Thu Mar 19, 2009 7:02 am
There seems to be a general dislike, shared by me, of IR "silently" changing data. That's why I put in a confirmation message. If the user says "No" to the cleanup, the Wav file generation exits. There is no way to "click away" the cleanup and so create an invalid Wav file, which seems to be one of Rob's concerns. If the user says "Yes" to the cleanup, the upgrade area is cleaned and the result is visible in the Raw Data page before you confirm (or cancel) the export itself.
By making IR put in a different checksum from that in the data file, IR.exe is using IRtoWAV to do something that cannot be done from command line use of IRtoWAV. I thought the point of linking IR.exe to IRtoWAV and ExtInstall was to make these easier to use, not to do something that they are otherwise not capable of doing. With my cleanup, you see and can save the cleaned file (again I emphasise that it is only the Upgrade area that is cleaned) and could use IRtoWAV from the command line to create the same WAV file.
If the objection is that the "garbage data" may not be garbage, just something that IR doesn't know about, then there is another option. Make the export contain not just the valid upgrades but also the garbage, i.e. extend the included data to the point at which the remainder of the upgrade area is filled with (an even number of) FFs. As the HCS08 remotes use an XOR checksum, it is unaffected by the omission of an even number of FFs.
There could even be, as Alain suggests, an Advanced option but not quite the one he suggests. The choice would be between (1) including the garbage data with no change to the content of IR, and (2) cleaning the upgrade area with the change visible to the user. I would make (1) be the default.
I really dislike the idea of a checksum going into the WAV file that cannot be seen in Raw Data. And no, it's not because I can't do it. I think it is the wrong thing to do. Rob thinks the IR data and the WAV file are two different things. My view is that the role of the WAV file is to copy selected data from IR to the remote. So you either copy it as it stands (garbage included) or after cleaning (garbage excluded), but in either case the data should be what is in the IR buffer. A different checksum would also make diagnosing WAV problems that much harder.
____________________
Graham
By making IR put in a different checksum from that in the data file, IR.exe is using IRtoWAV to do something that cannot be done from command line use of IRtoWAV. I thought the point of linking IR.exe to IRtoWAV and ExtInstall was to make these easier to use, not to do something that they are otherwise not capable of doing. With my cleanup, you see and can save the cleaned file (again I emphasise that it is only the Upgrade area that is cleaned) and could use IRtoWAV from the command line to create the same WAV file.
If the objection is that the "garbage data" may not be garbage, just something that IR doesn't know about, then there is another option. Make the export contain not just the valid upgrades but also the garbage, i.e. extend the included data to the point at which the remainder of the upgrade area is filled with (an even number of) FFs. As the HCS08 remotes use an XOR checksum, it is unaffected by the omission of an even number of FFs.
There could even be, as Alain suggests, an Advanced option but not quite the one he suggests. The choice would be between (1) including the garbage data with no change to the content of IR, and (2) cleaning the upgrade area with the change visible to the user. I would make (1) be the default.
I really dislike the idea of a checksum going into the WAV file that cannot be seen in Raw Data. And no, it's not because I can't do it. I think it is the wrong thing to do. Rob thinks the IR data and the WAV file are two different things. My view is that the role of the WAV file is to copy selected data from IR to the remote. So you either copy it as it stands (garbage included) or after cleaning (garbage excluded), but in either case the data should be what is in the IR buffer. A different checksum would also make diagnosing WAV problems that much harder.
____________________
Graham