CyberSimian wrote:mathdon wrote:It appears that I did this in April 2014. I have no recollection of doing so, or why I did it. There must have been some reason. I'll try to think what it might have been, and if there is some other way of meeting it.
Was this change in response to bug 16 in this post:
http://www.hifi-remote.com/forums/viewt ... ht=#111142
Bug 16 was:
(16) (BUG) In the "Device Upgrade Editor", the "Minimise" button (top right of window title bar) does not work correctly. The minimise animation occurs, but the minimised window remains on the screen.
Yes, it was. It is all coming back to me now. I think that what happened was as follows. Rightly or wrongly it was believed, by me and others, that the Device Editor window was modal. If you clicked on its title bar it did not gain the focus, that remained with the editor window. That was enough for me to believe, without explicitly trying it, that the whole window was disabled. Barf has discovered that is not the case now - the window remains functional even though the title bar
looks as if it is disabled. I am not aware of anything that may have changed the Device Editor from modal to non-modal. As Barf has also discovered, it is not trivial to make it modal, so I am inclined to believe that it always was non-modal and we were all mistaken. But whether that is so or not, what IS the case is that I acted in the belief that it was modal.
I presume the original behaviour, that before my "fix" of April 2014, was to mimic the behaviour of a real modal window that doesn't have a minimize button, so it effectively made that button ineffective. My fix allowed minimization, but so as not to leave a disabled window on the screen that one could do nothing with, I also minimized the main window.
I have now followed Barf's mods to make the Device Editor genuinely modal. Minimizing it but leaving the main window then gives a window on the screen that cannot even be moved, never mind itself minimized. That is not acceptable to me, so I have left active the code that minimizes the main window when you minimize the Device Editor.
However, I like happy users so I have also put in an option to make the Device Editor non-modal. Minimizing the editor then leaves an active main window on the screen. The problem with this is that if you edit the main window while the editor is still open, you can get inconsistencies. This option has to be "at your own risk". To emphasise this, when the editor is open then the status bar of the main window displays a warning "DO NOT EDIT THE MAIN WINDOW WHILE THE DEVICE EDITOR IS OPEN". I consider this an advanced option, so you will find it under Options/Advanced/Use non-modal Device Editor. Once selected, this option persists in future invocations of RMIR until deselected. It
is valid to deselect the option while the Device Editor is open, in which case it will change from non-modal to modal while open.
I will post a new RMIR shortly with this behaviour.
