I posted a correction to the RC5 protocol here
I think the RC5Translator is broken. The column width is too narrow in the functions tab to see whether the OBC>63 or not. I also can't get OBC to accept a number greater than 63 because I don't have a place to stash the top bit that really comes from bit 6 of fixed data for whichever device is chosen.
RC5 Protocols.ini -- corrected entry
Moderator: Moderators
-
jon_armstrong
- Expert
- Posts: 1238
- Joined: Sun Aug 03, 2003 9:14 pm
- Location: R.I.P. 3/25/2005
- Contact:
I'm still hoping for some comment from Greg on this topic.
Whether or not a kludge in the protocols.ini entry can cover up some of the symptoms, the RC5Translator code is wrong. (I haven't looked at what Jon did to see how much of the symptoms are covered up).
I reviewed the code, and it appears Greg was fixing a problem in import of KM files when he removed the functionality that I'd like to put back and also made the typo that looses one of the OBC bits.
I don't understand the KM import issue, so if I put back the functionality I want to put back, I'll likely rebreak the import.
Whether or not a kludge in the protocols.ini entry can cover up some of the symptoms, the RC5Translator code is wrong. (I haven't looked at what Jon did to see how much of the symptoms are covered up).
I reviewed the code, and it appears Greg was fixing a problem in import of KM files when he removed the functionality that I'd like to put back and also made the typo that looses one of the OBC bits.
I don't understand the KM import issue, so if I put back the functionality I want to put back, I'll likely rebreak the import.
I'll have some comments later, when I get a chance to look at it more carefully. I'm a bit busy at the moment.
-- Greg
Original RemoteMaster developer
JP1 How-To's and Software Tools
The #1 Code Search FAQ and it's answer (PLEASE READ FIRST)
Original RemoteMaster developer
JP1 How-To's and Software Tools
The #1 Code Search FAQ and it's answer (PLEASE READ FIRST)
I'm adding back the code to automatically change the selected device when the user enters an OBC incompatible with the OBC>63 flag for that device.
I'm also fixing the incorrect mask for the OBC.
Look for v1.02 soon.
I'm also fixing the incorrect mask for the OBC.
Look for v1.02 soon.
-- Greg
Original RemoteMaster developer
JP1 How-To's and Software Tools
The #1 Code Search FAQ and it's answer (PLEASE READ FIRST)
Original RemoteMaster developer
JP1 How-To's and Software Tools
The #1 Code Search FAQ and it's answer (PLEASE READ FIRST)